General cleanup #235
Merged
General cleanup #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AndreasArvidsson
commented
Aug 15, 2021
•
AndreasArvidsson
commented
- Removed inference context
- Unify inference of partial range and list targets
- Capitalize action names
- Added selection type to action preference
- Action breakpoint now supports scope types and in line breakpoints
- Process targets is now split into multiple files
- Moved assorted files into folders
- fixes Filter out duplicate selections #228
- fixes Move token scope type code out of navigation map #236
- fixes Add modifier preferences support #230
pokey
reviewed
Aug 19, 2021
| new SourceBreakpoint(new Location(uri, new Range(line, 0, line, 0))) | ||
| new SourceBreakpoint( | ||
| new Location(uri, target.selection.selection.start) | ||
| ) | ||
| ); | ||
| } | ||
| }); |
| target.modifier != null || | ||
| target.insideOutsideType != null | ||
| ); | ||
| } |
There was a problem hiding this comment.
This file is beautiful. So much cleaner
pokey
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.