Skip to content

Migrating markdown scopes #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2024
Merged

Migrating markdown scopes #2489

merged 3 commits into from
Jul 28, 2024

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jul 12, 2024 •
edited
Loading

Fixes #2378

Checklist

  • I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner July 12, 2024 06:50
@AndreasArvidsson AndreasArvidsson added lang-markdown Support for the Markdown family of markup languages scope-migration Migrating scopes to next-gen scope implementation labels Jul 12, 2024
pokey
pokey approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with minor comment

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner July 28, 2024 15:54
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Jul 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 28, 2024
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Jul 28, 2024
Merged via the queue into main with commit 6984b1a Jul 28, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the markdownMigration branch July 28, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
lang-markdown Support for the Markdown family of markup languages scope-migration Migrating scopes to next-gen scope implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"chuck section" in markdown doesn't remove the trailing lines
2 participants
@AndreasArvidsson @pokey