Skip to content

In memory text document #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 17, 2024
Merged

In memory text document #2520

merged 25 commits into from
Jul 17, 2024

Conversation

AndreasArvidsson
Copy link
Member

Checklist

  • I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner July 16, 2024 21:45
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quick thoughts; still need to review edit code

@AndreasArvidsson
Copy link
Member Author

@pokey Ready for another look :)

@pokey
Copy link
Member

pokey commented Jul 17, 2024

Made a bunch of tweaks and added a failing test. I personally think the test should pass, but we should just see how a VSCode editor handles that situation and do the same thing

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Jul 17, 2024

Ok your new test is now passing. I've tested and vscode is doing exactly what your test is specifying.

@pokey
Copy link
Member

pokey commented Jul 17, 2024

Ok your new test is now passing. I've tested and vscode is doing exactly what your test is specifying.

Ha nice. Yeah we rely on that behaviour in our range updater

@pokey pokey added this pull request to the merge queue Jul 17, 2024
@AndreasArvidsson AndreasArvidsson removed this pull request from the merge queue due to a manual request Jul 17, 2024
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 02eaebd Jul 17, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the inMemoryDocument branch July 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants