consistent-type-imports rule

[AndreasArvidsson]

related #2618
revives #1832

vscode quick fix import and auto import appears to be doing the right thing in regards to type only or runtime imports. Imports organize or imports fix unfortunately do not convert a runtime import to a type import if it's only used as a type. We probably need to rely on the linter to do that part for us.

Checklist

• [/] I have added tests
• [/] I have updated the docs and cheatsheet
• [/] I have not broken the cheatsheet

[pokey]

When you save, shouldn't the eslint fixer correct it tho?

[AndreasArvidsson]

When you save, shouldn't the eslint fixer correct it tho?

Yes if you have that enabled of course. I was just testing what vscode by itself would do.

[phillco]

lgtm, reviewed the base commit and a bit of the automatic changes

tbh kind of surprised this is a linter feature not a compiler one, given the benefits for transpilation

[auscompgeek]

tbh kind of surprised this is a linter feature not a compiler one, given the benefits for transpilation

TypeScript's verbatimModuleSyntax config enforces types are only imported with import type. The lint rule provides an autofixer though.