Tweaks to #709 #823
Merged
Tweaks to #709 #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasArvidsson
approved these changes
Jul 4, 2022
AndreasArvidsson
added a commit
that referenced
this pull request
Jul 5, 2022
* Added text based item scope * Cleaned up imports * Use text based item as a fallback * Updated tests * Don't look for items inside strings * More work on item stage * updated test * Replaced take test with clear test * updated item stage * Typescript now uses text based item * Use text based item for more languages * Use text based item for more languages * Cleanup * Added more tests * Added test * Added support for escaped strings * Added additional test * Added more tests * Light clean up and add test * cleanup * Include trailing delimiter in arguments * Cleanup * Cleanup * Don't expand for weak item target * Include pairs inside strings * Cleanup * p * Added item support to python argument list * Use new requireStrongContainment * Cleanup * Cleanup * Added complex surrounding pair scope type * Tweaks to #709 (#823) * Tweaks to text-based item PR * More tweaks and tests * More doc string Co-authored-by: Andreas Arvidsson <[email protected]> * Revert "Added complex surrounding pair scope type" This reverts commit 95acb52. * Cleanup * Create single union of items * Excluded separator from domain * Cleanup * Updated tests * Update src/processTargets/modifiers/ItemStage/tokenizeRange.ts Co-authored-by: Pokey Rule <[email protected]> * Update src/processTargets/modifiers/ItemStage/tokenizeRange.ts Co-authored-by: Pokey Rule <[email protected]> * Update src/languages/python.ts Co-authored-by: Pokey Rule <[email protected]> * Cleanup * Tweaks Co-authored-by: Pokey Rule <[email protected]> Co-authored-by: Andreas Arvidsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist