Standardize DatePrimitive -> Date interaction #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a part of @gregchapman-dev comment on 38d103a Standardizes that Date.year / month / etc. hold int or None, not strings ever. Sanity check month, day, hour, minute, second. Wondering if we should be recording hour/minute/second at all -- thoroughly under tested before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of @gregchapman-dev comment on 38d103a
Does not create a machine readable representation for DateBetween, etc. -- happy to include that as something like 'humdrumStr()' -- since it is being parsed elsewhere, though I think the default string should be as human readable as possible.
Standardizes that Date.year / month / etc. hold int or None, not strings ever.
Sanity check month, day, hour, minute, second.
Wondering if we should be recording hour/minute/second at all -- thoroughly under tested before.