Skip to content

Conversation

@jacobtylerwalls
Copy link
Member

Fixes #1400

Previously, the part staff exporter overzealously deduplicated <barline> tags (including child <repeat> tags).

Now, it checks that the location attribute is identical before deduplicating.

Prevents losing forward barlines as reported in #1400.

@gregchapman-dev does this resolve your issue?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 93.078% when pulling 91cd8e6 on partStaff-repeats into 29b67ed on master.

@mscuthbert
Copy link
Member

Thanks! Looks very good. Merging.

(This might also fix an issue with final barlines disappearing from one part in the piano scores).

@mscuthbert mscuthbert merged commit 1c46fc5 into master Sep 14, 2022
@mscuthbert mscuthbert deleted the partStaff-repeats branch September 14, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reading and writing xml file remove forward repeats

4 participants