Lowercase some RomanNumeral figures created with integers #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscuthbert
approved these changes
Nov 19, 2022
Member
mscuthbert
left a comment
mscuthbert
left a comment
There was a problem hiding this comment.
Looks great to me, good approach.
music21/roman.py
Outdated
Comment on lines
4405
to
4406
| '''https://github.com/cuthbertLab/music21/issues/1450''' | ||
| minorKeyObj = key.Key("c") |
Member
There was a problem hiding this comment.
trying to standardize docstrings as always like:
'''
adfahdfkladf
'''
even if a one-liner.
The linter should be catching the double quote "c" -- not sure why not here.
Member
Author
|
Thanks, Myke. Feel free to unpin |
MarkGotham
added a commit
to MarkGotham/music21
that referenced
this pull request
Dec 7, 2022
MarkGotham
added a commit
to MarkGotham/music21
that referenced
this pull request
Dec 7, 2022
mscuthbert
added a commit
that referenced
this pull request
Dec 7, 2022
adds doc for RN from int, following #1481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1450
Previously, RomanNumerals created with integer figures were always uppercase, even when
caseMatterswas True.Now, certain figures are lowercased according to the mode.
cc/ @MarkGotham would you be willing to review?
I didn't use structural pattern matching per this comment:
music21/music21/midi/translate.py
Lines 1281 to 1283 in d77f405