Add support for delayed turns (and delayed inverted turns). #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hoping this can make v9 as well. |
mscuthbert
requested changes
Feb 25, 2023
Member
mscuthbert
left a comment
mscuthbert
left a comment
There was a problem hiding this comment.
This is GREAT! There is one substantive issue (last comment) that needs to be addressed about float delays, and a few style things, but hope I can get this in today. Thanks!
Contributor
Author
|
Assuming all the checks pass, this should be ready to go. |
Contributor
Author
|
@mscuthbert Checks have passed, looks ready to go. |
Member
|
Great. Will be in the office later today and looks like it's a ready to merge. |
Member
|
Merging. Thinking in the future we might need to have something like "minQuarterLength" and "maxQuarterLength" instead of a bare quarterLength idea -- but that's an idea for later. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.