Fix pylint recommendations #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint now recommends using `yield from` and the use of `min/max` to simplify if statements.
| for group in olDict.values(): | ||
| if len(group) > maxVoiceCount: | ||
| maxVoiceCount = len(group) | ||
| maxVoiceCount = max([len(group) for group in olDict.values()] + [1]) |
Member
There was a problem hiding this comment.
This isn't necessarily better than the prior version, so although it's not worth reverting, it might have been worth adding a disable. To keep in mind for future lint additions.
Contributor
Author
There was a problem hiding this comment.
I agree, I'm pretty sure there should be a simpler option (maybe max([..], default=1), which would be ok if we know at least one group is not empty), but I wasn't able to confirm it quickly.
jacobtylerwalls
approved these changes
Mar 4, 2024
Member
jacobtylerwalls
left a comment
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Great, appreciate your help keeping the pipeline green!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylint now recommends using
yield fromand the use ofmin/maxto simplify if statements.