Fix mypy 1.16 issues #1794
Fix mypy 1.16 issues #1794
Conversation
Improve typing for music21 based on issues uncovered in mypy 1.16. Fix error in `Interval.noteEnd = None` -- setting noteStart, noteEnd, pitchStart, or pitchEnd to None raised exceptions
|
|
||
| def solutionLegend(self, compress=False): | ||
| def solutionLegend(self, compress: bool = False) -> list[ | ||
| list[str|list[tuple[int|str, str|None]]] |
There was a problem hiding this comment.
For complex types like this that you re-use, you can define a type alias. It might make it a bit clearer to understand when the same type is returned from different functions, or annotated on different variables.
https://docs.python.org/3/library/typing.html#typing.TypeAlias
There was a problem hiding this comment.
Thanks Andrew -- we use TypeAliases all over the place -- I'm leaving this in for now so that I can see that this is something to change/fix/standardize in the next not-backwards compatible version. There's no way if we had had Python typing when we wrote this code that anyone involved with music21 would have ever have let this come in. Next version will definitely be something cleaner like list[tuple[str, list[tuple[str, str]]]] and THAT will be worthy of a typealias.
Improve typing for music21 based on issues uncovered in mypy 1.16.
Fix error in
Interval.noteEnd = None-- setting noteStart, noteEnd, pitchStart, or pitchEnd to None raised exceptions