Skip to content

Schema feedback #12

Closed
Closed
@kandersolar

Description

@kandersolar

A few things I noticed about the schema and test cases:

  • The test case json files include Temperature for each IV curve, but that's not included in the schema
  • The test case json files set Datetime to the empty string, which I think is not a valid value for the schema's date-time format
  • Consider restricting Sweep direction to particular values (e.g. "forward")
  • Seems a bit strange to have cells_in_series specified next to the actual voltage and current values at the IV curve level

Note that the first two items also apply to the json files in pvlib/pvlib-python#1573.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions