Synching with base / master

.github/CONTRIBUTING.md

@@ -0,0 +1,4 @@
+Contributing
+============
+
+We welcome your contributions! Please see the [contributing](http://pvlib-python.readthedocs.io/en/latest/contributing.html) page for information about how to contribute.

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,29 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Versions:**
+ - ``pvlib.__version__``: 
+ - ``pandas.__version__``: 
+ - python:
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,17 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/support-question.md

@@ -0,0 +1,10 @@
+---
+name: Support question
+about: If you have a support or usage question, please see the pvlib stack overflow
+  tag or the pvlib-python google group
+
+---
+
+pvlib usage questions can be asked on [Stack Overflow](http://stackoverflow.com) and tagged with the [pvlib](http://stackoverflow.com/questions/tagged/pvlib) tag.
+
+The [pvlib-python google group](https://groups.google.com/forum/#!forum/pvlib-python) is used for discussing various topics of interest to the pvlib-python community. We also make new version announcements on the google group.

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,17 +1,19 @@
 pvlib python pull request guidelines
 ====================================
 
-Thank you for your contribution to pvlib python!
+Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.
 
-You may submit a pull request with your code at any stage of completion, however, before the code can be merged the following items must be addressed:
+You may submit a pull request with your code at any stage of completion.
+
+The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:
 
  - [ ] Closes issue #xxxx
- - [ ] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
- - [ ] Code quality and style is sufficient. Passes ``git diff upstream/master -u -- "*.py" | flake8 --diff`` and/or landscape.io linting service.
- - [ ] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
+ - [ ] I am familiar with the [contributing guidelines](http://pvlib-python.readthedocs.io/en/latest/contributing.html).
+ - [ ] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  - [ ] Updates entries to `docs/sphinx/source/api.rst` for API changes.
  - [ ] Adds description and name entries in the appropriate `docs/sphinx/source/whatsnew` file for all changes.
-
-Please don't hesitate to ask for help if you're unsure of how to accomplish any of the above. You may delete all of these instructions except for the list above.
+ - [ ] Code quality and style is sufficient. Passes ``git diff upstream/master -u -- "*.py" | flake8 --diff``
+ - [ ] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
+ - [ ] Pull request is nearly complete and ready for detailed review.
 
 Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

.gitignore

@@ -1,4 +1,5 @@
 # Byte-compiled / optimized / DLL files
+.pytest_cache/
 __pycache__/
 *.py[cod]
 

appveyor.yml

@@ -28,7 +28,7 @@ install:
     - cmd: conda info -a
 
     # install depenencies
-    - cmd: conda create -n test_env --yes --quiet python=%PYTHON_VERSION% pip numpy scipy pytables pandas nose pytest pytz ephem numba siphon -c conda-forge
+    - cmd: conda create -n test_env --yes --quiet python=%PYTHON_VERSION% pip numpy scipy pytables pandas nose pytest pytz ephem numba siphon pytest-mock -c conda-forge
     - cmd: activate test_env
     - cmd: python --version
     - cmd: conda list

ci/requirements-py27-min.yml

@@ -4,6 +4,7 @@ dependencies:
     - pytz
     - pytest
     - pytest-cov
+    - pytest-mock
     - nose
     - pip:
         - coveralls

ci/requirements-py27.yml

@@ -14,6 +14,7 @@ dependencies:
     - siphon
     - pytest
     - pytest-cov
+    - pytest-mock
     - nose
     - pip:
         - coveralls

ci/requirements-py34.yml

@@ -14,6 +14,7 @@ dependencies:
     - siphon
     - pytest
     - pytest-cov
+    - pytest-mock
     - nose
     - pip:
         - coveralls

ci/requirements-py35.yml

@@ -14,6 +14,7 @@ dependencies:
     - siphon
     - pytest
     - pytest-cov
+    - pytest-mock
     - nose
     - pip:
         - coveralls

ci/requirements-py36.yml

@@ -14,6 +14,7 @@ dependencies:
     #- siphon
     - pytest
     - pytest-cov
+    - pytest-mock
     - nose
     - pip:
         - coveralls

docs/sphinx/source/api.rst

@@ -65,7 +65,6 @@ algorithm.
 
    spa
 
-
 Correlations and analytical expressions for low precision solar position
 calculations.
 
@@ -80,6 +79,7 @@ calculations.
    solarposition.equation_of_time_pvcdrom
    solarposition.hour_angle
 
+
 Clear sky
 =========
 
@@ -202,9 +202,22 @@ Functions relevant for the single diode model.
    :toctree: generated/
 
    pvsystem.calcparams_desoto
+   pvsystem.calcparams_pvsyst
    pvsystem.i_from_v
    pvsystem.singlediode
    pvsystem.v_from_i
+   pvsystem.max_power_point
+
+Low-level functions for solving the single diode equation.
+
+.. autosummary::
+   :toctree: generated/
+
+   singlediode_methods.estimate_voc
+   singlediode_methods.bishop88
+   singlediode_methods.bishop88_i_from_v
+   singlediode_methods.bishop88_v_from_i
+   singlediode_methods.bishop88_mpp
 
 SAPM model
 ----------
@@ -231,7 +244,6 @@ PVWatts model
    pvsystem.pvwatts_ac
    pvsystem.pvwatts_losses
 
-
 Other
 -----