pass customParameters from TVCallParametersImpl to TVParametersImpl #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cybex-dev
requested changes
Apr 15, 2025
| @@ -68,7 +68,7 @@ class TVCallInviteParametersImpl(storage: Storage, callInvite: CallInvite) : TVP | |||
| } | |||
| } | |||
|
|
|||
| class TVCallParametersImpl(storage: Storage, call: Call, callTo: String, callFrom: String, customParameters: Map<String, String> = emptyMap()) : TVParametersImpl(storage) { | |||
| class TVCallParametersImpl(storage: Storage, call: Call, callTo: String, callFrom: String, customParameters: Map<String, String> = emptyMap()) : TVParametersImpl(storage, "", customParameters) { | |||
There was a problem hiding this comment.
Can we throw in TVParametersImpl(storage, call.sid ?: "", customParameters) instead, otherwise fantastic PR.
|
Fantastic catch, thank you for your contribution. |
|
@cybex-dev any plans to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android when making a call like this:
the
__TWI_RECIPIENT_NAMEparameter is not respected by the android platform code, but everything in the android code is set up so that it should work.The change in this PR make the logic actually work for outgoing calls.