Toward next Major version #91

nickbalestra · 2017-04-07T17:38:03Z

As per #85

Goal is to get to a state where we can work together and merge into a single flavor that will allows for both choosing the language (typescript/javascript) and the stream library (xstream, most, rxjs)

Current status

To be done in follow-up PRs:

adhoc templates for typescript
adhoc webpack configs for typescript
cleaner build assets output (js/ css/ images/)
eslint/prettier
CSS Autoprefixing
App Tests (jest/time)
Move Counter example
https://github.com/Widdershin/cycle-restart
Scripts/info based for build

jvanbruegge · 2017-04-08T09:48:30Z

Do not use snabbdom-jsx it has bugs, thanks to a few PRs from me https://github.com/Swizz/snabbdom-pragma is the way to go
Why not use webpack-blocks, it makes config a lot easier (for us and for the people after eject)
I just merged the 2.0.0 version of the one-fits-all flavor, so that might be helpful

nickbalestra · 2017-04-08T10:58:19Z

Thanks!
I prefer to be a bit closer to the "webpack-metal". So that we don't rely on another project and users don't have to learn another thing. If you eject then you suppose to be able to deal with webpack and is the your issue from that point onward. So I think is better to leave that decision to the user and don't make too opinionated decision for what he'll get after eject, the more metal, the better imho.
In this direction I find the create-react-app way of commenting the webpack configs vert compelling and of high value to an 'ejected-user` (and also for us as we really know what is going on and we have full control).

I'm structuring it in a way that Iside configs and template/src we would have 2 folders, 'javascript' and 'typescript' so that we can mantain ad-hoc configuration and source file for both.

I aim to push something for you to look at today/tomorrow

jvanbruegge · 2017-04-08T11:02:45Z

packages/cycle-scripts/template/public/index.html

@@ -1,15 +1,12 @@
 <!DOCTYPE html>


This is not needed when you use index.ejs and the HTMLWebpackPlugin

no need to use an .ejs with the TMLWebpackPlugin, you can just use an html file and inject into it, no?

not sure, either way, you have both

hehe...is . WIP :) not sure i have pushed everything.

Agree that there should be only 1

jvanbruegge · 2017-04-08T11:04:47Z

packages/cycle-scripts/template/src/JavaScript/app.js

@@ -0,0 +1,12 @@
+module.exports = replacements => `${replacements.import}
+
+export function App (sources) {


I would use the counter example as the base app, like I did here. Has the advantage of showing MVI

Totally agree

jvanbruegge · 2017-04-08T11:05:38Z

packages/cycle-scripts/template/src/JavaScript/app.test.js

@@ -1,7 +1,8 @@
-// import assert from 'assert'
+module.exports = replacements => `// import assert from 'assert'


Take a look at the new test setup in the one-fits-all flavor

For the tests? Yes those are nice, wi'll defintiely bring/merge all those ins

jvanbruegge · 2017-04-08T11:11:38Z

What are the dev-utils for?

nickbalestra · 2017-04-08T11:15:24Z

I initially forked them from react-dev-utils, but now using them directly, no need to fork them. It provide a nice little sets of utilities, mainly a great webpackHotDevClient with overlay of errors & co. it make the experience super nice! => https://github.com/facebookincubator/create-react-app/tree/master/packages/react-dev-utils

jvanbruegge · 2017-04-08T11:25:28Z

https://github.com/facebookincubator/create-react-app/tree/master/packages/react-dev-utils#webpackhotdevclientjs

It currently supports only Webpack 1.x

This is not good, WP 1 was official deprecated

jvanbruegge · 2017-04-08T11:27:33Z

We could also incorporate https://github.com/Widdershin/cycle-restart to make hot reloading cooler

nickbalestra · 2017-04-08T11:29:18Z

Lol I guess someone should do a PR as they are using [webpack2]...

https://pbs.twimg.com/media/B3qIJLFCcAEJLWm.jpg
(https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/package.json#L57) and work fine (I've also tested it without any issue)

yes that will be awesome. Added to the list!

nickbalestra · 2017-04-08T11:32:40Z

@jvanbruegge Once I've cleaned up some stuff, I'll ping you so that you can bring in the typeScripts parts and we can then work together on putting it together. Would be great to launch it at the cycleconf

jvanbruegge · 2017-04-08T11:33:02Z

sure
indeed

jvanbruegge · 2017-04-08T11:45:58Z

Maybe we should also have a third question about test runner, ava seems to be quite hot nowadays. So we could provide tests with mocha-webpack or ava-webpack

nickbalestra · 2017-04-08T11:50:04Z

Imho test-suite choice is a bit out of scope for this PR. I'll rather keep the same test suite for the whole monorepo (jest atm). We can always add that later in if we believe is a must.

jvanbruegge · 2017-04-08T11:51:02Z

does jest work with webpack?

nickbalestra · 2017-04-08T11:51:26Z

-> https://facebook.github.io/jest/docs/webpack.html

nickbalestra · 2017-04-08T11:56:23Z

I think I'll brake this PR. Once I got the whole JS part in, we can review it and merge.
Then we can open PRs for

moving to counter example
adding typescript src
adding tests
adding css/autoprefixer
Widdershin/cycle-restart
eslinting/prettier
docs

jvanbruegge · 2017-04-08T11:57:29Z

Yeah, i think this is better

nickbalestra · 2017-04-08T11:58:18Z

Cool,
I'll try to have this one ready for tomorrow so that we can divide and conquer this. Exciting times!
We can put all those releases behind a next flag until we hit major

nickbalestra · 2017-04-09T22:22:25Z

@jvanbruegge I've done everything. Few major things:

CLI if no flavor is passed now prompt user for language (javascript, typescript(not yet working as files are missing)) and stream library (xstream, most, rxjs).
If flavor is passed, prompting is delegated to flavor, cycle-scripts support both so that you can run it locally or as a fork with no issue.
Unique file for configuring strings to interpolate templates and various dependencies (basic, language, and stream-lib related) - /configs/flavor.js
It now support yarn (by autodetecting it (pass --noyarn flag if you have yarn but want to force it to use npm instead)
On bundling, errors are displayed on the page via an overlay
scripts structure now has configs/<language> (typescript to be added), same for template/src/<language>
No need for adding babel config to packaje.json anymore of flavor anymore, directly declared in the webpack.configs as we use webpack node.api)
and a lot more...

I think this should be a good state to move forward as per our dicussion.
Let me know

nickbalestra · 2017-04-09T22:26:52Z

Addresses #98 #11 #70(via native template literals)

jvanbruegge · 2017-04-09T22:49:32Z

The points are good, but i have few remarks about the code (only had quick look):

the point about the babelrc was to allow changes, eg for the env-preset if you cant di this if its hidden away.
using the webpack node api means you are leaving traces post-eject (most likely a scripts folder), im not really a fan of this. A partial solution would be to copy all config like normal and have a seperate npm pacjage with the scripts. that way you dont have to have them in your git (dont like this either)
im not sure if we need seperate js/ts templates. TSC. if you compile ts to es6 you will get your js template for free
i will take a deeper look tomorrow

jvanbruegge · 2017-04-10T00:09:18Z

There is a lot of duplication in the webpack configs, thats why i like webpack-blocks. Even without i would refactor at least to a common file and seperate prod and dev files

nickbalestra · 2017-04-10T07:07:32Z

I know, and you could also use something like webpack merge. But to be honest, is it that bad to have just two separate plain config files, one for dev and one for prod?

Maybe something we can explore in a separate PR after we bring in typescript and the other things? perhaps bringing out 'paths' in its own file..

If Ok for you I'm going to merge this

jvanbruegge · 2017-04-10T08:11:56Z

ok

jvanbruegge · 2017-04-10T08:12:42Z

i would wait with the release untul we got a few PRs done

nickbalestra · 2017-04-10T08:16:25Z

Totally agree (also cause it will brake if you select typescript now :D)!

The only version published will be a minor with scoped core-scripts as per #100.

If we need for testing and try I suggest we'll release the work we are now doing behind a npm flag until we get to a rc state

jvanbruegge · 2017-04-10T08:21:19Z

Can you add me to this repo? Then i can assign myself to the tickets and dont have to constantly update my fork

nickbalestra · 2017-04-10T08:28:52Z

Sure, done 😃

Remove hapi-cycle, add unicycle

nickbalestra changed the title ~~New scripts~~ [WIP] New scripts Apr 8, 2017

jvanbruegge reviewed Apr 8, 2017

View reviewed changes

nickbalestra mentioned this pull request Apr 8, 2017

[CCA-Diversity] Bring typescript src into core-flavor #92

Closed

nickbalestra changed the title ~~[WIP] New scripts~~ Toward next Major version Apr 9, 2017

Nick Balestra added 26 commits April 10, 2017 09:29

added more configs

1561a2a

better usage of webpack adn webpack-dev-server for start script

9c837fb

updating deps

7c86f19

wip dev

762880d

wip dev

bae8c7e

cycle-dev-utils package

7662c65

deps

bcef3e7

better ad hoc webpack configs

ea2b644

wip scripts

95079e2

removed old utils

89e3142

transform-object-rest-spread

ebdb1a7

eject wip

707bad6

interactive init

8b0ae11

relying on react-dev-utils

db78706

initial iniquirer for core flavor

0fb974a

initQuestion in case that the flavor is runned locally or as a fork

25ec240

inquirer wip

6d9ce48

flavors wip

2911a66

yarn compatible

ab77193

cca cleanup

e22441c

cca tests cleanup

3f0de48

cycle-scripts reworks

6ec1be2

new cli version to work with correct core flavor version

d7bc1dc

forceprompt flag

72cbd42

fix eject abort script

9a48c9f

better core-scripts fix

a131828

nickbalestra force-pushed the new-scripts branch from 96c9c70 to a131828 Compare April 10, 2017 08:32

nickbalestra merged commit 351825a into master Apr 10, 2017

nickbalestra deleted the new-scripts branch April 10, 2017 08:47

perjerz pushed a commit to perjerz/create-cycle-app that referenced this pull request Nov 12, 2018

Merge pull request cyclejs-community#91 from wyqydsyq/patch-1

02c22fa

Remove hapi-cycle, add unicycle

		@@ -0,0 +1,12 @@
		module.exports = replacements => `${replacements.import}

		export function App (sources) {

		@@ -1,7 +1,8 @@
		// import assert from 'assert'
		module.exports = replacements => `// import assert from 'assert'

Toward next Major version #91

Toward next Major version #91

Uh oh!

Conversation

nickbalestra commented Apr 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvanbruegge commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickbalestra commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jvanbruegge commented Apr 8, 2017

Uh oh!

nickbalestra commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvanbruegge commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvanbruegge commented Apr 8, 2017

Uh oh!

nickbalestra commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickbalestra commented Apr 8, 2017

Uh oh!

jvanbruegge commented Apr 8, 2017

Uh oh!

jvanbruegge commented Apr 8, 2017

Uh oh!

nickbalestra commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvanbruegge commented Apr 8, 2017

Uh oh!

nickbalestra commented Apr 8, 2017

Uh oh!

nickbalestra commented Apr 8, 2017

Uh oh!

jvanbruegge commented Apr 8, 2017

Uh oh!

nickbalestra commented Apr 8, 2017

Uh oh!

nickbalestra commented Apr 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickbalestra commented Apr 9, 2017

Uh oh!

jvanbruegge commented Apr 9, 2017

Uh oh!

jvanbruegge commented Apr 10, 2017

Uh oh!

nickbalestra commented Apr 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvanbruegge commented Apr 10, 2017

Uh oh!

jvanbruegge commented Apr 10, 2017

Uh oh!

nickbalestra commented Apr 10, 2017

nickbalestra commented Apr 7, 2017 •

edited

Loading

jvanbruegge commented Apr 8, 2017 •

edited

Loading

nickbalestra commented Apr 8, 2017 •

edited

Loading

nickbalestra commented Apr 8, 2017 •

edited

Loading

jvanbruegge commented Apr 8, 2017 •

edited

Loading

nickbalestra commented Apr 8, 2017 •

edited

Loading

nickbalestra commented Apr 8, 2017 •

edited

Loading

nickbalestra commented Apr 9, 2017 •

edited

Loading

nickbalestra commented Apr 10, 2017 •

edited

Loading