19 inline menu editor #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check_column_type() to validate action types
- Update update_col_list_with_classes()
DivadNojnarg
requested changes
Apr 17, 2025
There was a problem hiding this comment.
@olajoke Thanks:
- Can we add an example in the vignette to illustrate how this works?
- Ensure we have minimum test coverage for this.
| #' @param column_type Column type. By default, the column type is inferred from the data type of the column. | ||
| #' There are 7 possible options: | ||
| #' \itemize{ | ||
| #' \item \code{"text"} for text columns. |
There was a problem hiding this comment.
We can use markdown syntax in roxygen2. It's easier than having \itemize ...
Instead it can be:
#' There are 7 possible options:
#' - Option 1
#' - Option 2| #' \item \code{"image"} for image columns. | ||
| #' \item \code{"radio"} for radio columns. | ||
| #' \item \code{"multilinetext"} for multiline text in columns. | ||
| #' \item \code{"multilinetext"} for multiline text columns. |
There was a problem hiding this comment.
Using markdown, \code{} becomes `code`
| - `"menu"`: For dropdown menu selection columns | ||
|
|
||
| The `column_type` parameter is optional. If it is not specified, the column type will be inferred from the data type. | ||
| If `column_type` parameter is optional. If it is not specified, the column type will be inferred from the data type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.