Skip to content

Conversation

olajoke
Copy link
Collaborator

@olajoke olajoke commented May 2, 2025

Addresses issue 'Implement column grouping' #40

@olajoke olajoke requested a review from DivadNojnarg May 2, 2025 15:41
@DivadNojnarg
Copy link
Collaborator

@olajoke I don't know what I am doing wrong but when I run:

cheetah(
  iris,
  columns = list(
    Sepal.Length = column_def(name = "Length"),
    Sepal.Width = column_def(name = "Width"),
    Petal.Length = column_def(name = "Length"),
    Petal.Width = column_def(name = "Width")
  ),
  column_group = list(
    column_group(
      name = "Sepal",
      columns = c("Sepal.Length", "Sepal.Width"),
      header_style = list(textAlign = "center", bgColor = "#fbd4dd")
    ),
    column_group(
      name = "Petal",
      columns = c("Petal.Length", "Petal.Width"),
      header_style = list(textAlign = "center", bgColor = "#d8edfc")
    )
  )
)

I get this:

Screenshot 2025-05-05 at 10 56 16 which I am not super sure to understand, as the output does not look very informative.

@olajoke
Copy link
Collaborator Author

olajoke commented May 5, 2025

@olajoke I don't know what I am doing wrong but when I run:

cheetah(
  iris,
  columns = list(
    Sepal.Length = column_def(name = "Length"),
    Sepal.Width = column_def(name = "Width"),
    Petal.Length = column_def(name = "Length"),
    Petal.Width = column_def(name = "Width")
  ),
  column_group = list(
    column_group(
      name = "Sepal",
      columns = c("Sepal.Length", "Sepal.Width"),
      header_style = list(textAlign = "center", bgColor = "#fbd4dd")
    ),
    column_group(
      name = "Petal",
      columns = c("Petal.Length", "Petal.Width"),
      header_style = list(textAlign = "center", bgColor = "#d8edfc")
    )
  )
)

I get this:

Screenshot 2025-05-05 at 10 56 16 which I am not super sure to understand, as the output does not look very informative.

@DivadNojnarg That is strange. Did you recompile with packer before running it. You are supposed to get something like this:
Screenshot 2025-05-05 at 11 44 24

@DivadNojnarg
Copy link
Collaborator

Thanks @olajoke. Yes if I run packer::bundle_prod() I get the correct output. Can you commit the update JS artefact? It seems that the current JS code does not include the latest changes.

@olajoke
Copy link
Collaborator Author

olajoke commented May 5, 2025

Thanks @olajoke. Yes if I run packer::bundle_prod() I get the correct output. Can you commit the update JS artefact? It seems that the current JS code does not include the latest changes.

@DivadNojnarg Oh I see. I will commit the updated JS artefact then. Thanks

Copy link
Collaborator

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@olajoke olajoke merged commit 214b67e into development May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants