Skip to content

Add fastlane metadata #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

singpolyma
Copy link
Contributor

For #954

@singpolyma
Copy link
Contributor Author

Or maybe fdroid would be ok with this in the android subdirectory? not sure

@julian-CStack
Copy link
Collaborator

Or maybe fdroid would be ok with this in the android subdirectory? not sure

Not sure. I'm not very familiar with fdroid or fastlane.

Looking at https://docs.flutter.dev/deployment/cd#fastlane it seems it should be?

@singpolyma
Copy link
Contributor Author

@julian-CStack it's not about what fastlane supports but what fdroid supports. It seems they look in a small number of places so in root like this is probably best. https://gitlab.com/fdroid/rfp/-/issues/2819#note_2213442386

@julian-CStack
Copy link
Collaborator

@julian-CStack it's not about what fastlane supports but what fdroid supports. It seems they look in a small number of places so in root like this is probably best. https://gitlab.com/fdroid/rfp/-/issues/2819#note_2213442386

I would expect that if fdroid depends on fastlane, fdroid would work with what fastlane supports. But like I said before, I haven't don't have any experience with either fdroid or fastlane.

I'm ok with whatever works.

danrmiller
danrmiller previously approved these changes Jan 13, 2025
Copy link
Collaborator

@danrmiller danrmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hey buddy!

@julian-CStack julian-CStack changed the base branch from main to staging January 13, 2025 21:06
@julian-CStack julian-CStack dismissed danrmiller’s stale review January 13, 2025 21:06

The base branch was changed.

@julian-CStack julian-CStack merged commit ad66702 into cypherstack:staging Jan 13, 2025
@singpolyma singpolyma deleted the fastlane branch January 13, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants