-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: add webpack 4 removal guide #6164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AtofStryker
wants to merge
1
commit into
release/15.0.0
Choose a base branch
from
chore/add_webpack_4_removal_guide
base: release/15.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cypress-documentation
|
Project |
cypress-documentation
|
Branch Review |
chore/add_webpack_4_removal_guide
|
Run status |
|
Run duration | 08m 44s |
Commit |
|
Committer | AtofStryker |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
301
|
View all changes introduced in this branch ↗︎ |
UI Coverage
10.93%
|
|
---|---|
|
2399
|
|
3
|
Accessibility
96.91%
|
|
---|---|
|
0 critical
4 serious
4 moderate
0 minor
|
|
26
|
MikeMcC399
reviewed
Apr 29, 2025
MikeMcC399
reviewed
Apr 29, 2025
MikeMcC399
reviewed
Apr 29, 2025
MikeMcC399
reviewed
Apr 29, 2025
560e0c7
to
df0d7e9
Compare
@MikeMcC399 I reworked this guide quite a bit this morning if you want to take another pass at it. I am going to re review it with fresh eyes either later today or tomorrow morning. |
MikeMcC399
reviewed
Apr 29, 2025
MikeMcC399
reviewed
Apr 29, 2025
MikeMcC399
reviewed
Apr 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of minor suggestions in-line
df0d7e9
to
0508ae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the migration guide for webpack 4 removal in Cypress 15