chore: fix net stubbing flake#20297
Merged
Merged
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
flotwig
approved these changes
Feb 22, 2022
BlueWinds
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
The net_stubbing test should delay the same amount on every response has been flaky. It typically fails because the delay ends up being slightly over the acceptable buffer of 50 ms.
The other tests in this file handle the buffer slightly differently giving a window of 200 ms by saying the actual delay needs to be within (delay + 100 +/- 100). I updated this test (which is really just testing that each subsequent interception also applies the delay) to do the same and it seems to be passing more consistently. It's worth noting that the delay specified is a "minimum" and not really intended to be super accurate (https://docs.cypress.io/api/commands/intercept#Response-object-properties).
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?