fix: dont throw warning on variable data selector#272
Merged
jennifer-shehane merged 3 commits intocypress-io:masterfrom Aug 14, 2025
Merged
fix: dont throw warning on variable data selector#272jennifer-shehane merged 3 commits intocypress-io:masterfrom
jennifer-shehane merged 3 commits intocypress-io:masterfrom
Conversation
|
Collaborator
|
Many thanks for your contribution! |
jennifer-shehane
requested changes
Aug 14, 2025
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
jennifer-shehane
approved these changes
Aug 14, 2025
Member
jennifer-shehane
left a comment
jennifer-shehane
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Member
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes (partially*) #270
Description
cy.get(), no warning are being thrown. This is being done by first saving variable declaration of aliases or data selectors into a Map, and then when looking atcy.get()command it is also looking up potential use of variable in the map.*partially because cross-file declaration does not seems to be feasible, as ESlint only validate file by file.