Restart SNTP client when we have an IPv4 or IPv6 address #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the restarting of the SNTP client when the network interface has a valid IP address. This was broken in changeset 9246ef for IPv4. Note that for IPv6 the SNTP server can take up to 15 seconds to be used due to the async nature of stateless DHCPv6 and SLAAC. For IPv4 it takes effect immediately as the address and SNTP server come in the same packet. Tests: - Verify operation on dual-stack IPv4/IPv6: - DHCPv6 only network (no DHCPv4 server present) - DHCPv4 and DHCPv6 network - Verify operation on IPv4 only stack - Check SNTP restart with LwIP logging enabled - Verify time is requested and received via Wireshark - Verify system time is set Signed-off-by: David J. Fiddes <[email protected]>
|
Sorry ti took a while to get this fix together. I spent too long chasing a nasty looking stack corruption because my lwip2-src was based off the tip rather than the last stable release as you use. Not quite sure why that would make a difference. I'll try and investigate if I get time. |
|
SNTP app patch submitted to the LwIP project for review: https://savannah.nongnu.org/patch/index.php?9749 |
|
Thanks ! I will commit this to Arduino asap |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the restarting of the SNTP client when the network
interface has a valid IP address. This was broken in changeset
9246ef for IPv4.
Note that for IPv6 the SNTP server can take up to 15 seconds to
be used due to the async nature of stateless DHCPv6 and SLAAC.
For IPv4 it takes effect immediately as the address and SNTP
server come in the same packet.
Tests:
Signed-off-by: David J. Fiddes [email protected]