Invisible avatar is still clickable in .top-nav-short

[alefi87]

When scrolling so the avatar fades out and the main nav turns "short" the avatar is still clickable. You can't see it, but the hitbox is still there, so it's a bit confusing, not to mention that it might hijack clicks on some of the content under it (e.g. another link in the text).

I guess that one is tough to solve with pure CSS since display is not affected by transition rules, but since JS is used for certain functionality, perhaps the avatar animation might as well be done with something like jQuery('.avatar-container img').fadeOut(500)?

[daattali]

You're right that's a behaviour I've known about for a while but never seemed to actually bother anyone. If you find a clean way to fix it, you're welcome to submit a PR!

…

On Dec 26, 2017 9:46 AM, "Alexander Filatov" ***@***.***> wrote: When scrolling so the avatar fades out and the main nav turns "short" the avatar is still clickable. You can't see it, but the hitbox is still there, so it's a bit confusing, not to mention that it might hijack clicks on some of the content under it (e.g. another link in the text). I guess that one is tough to solve with pure CSS since display is not affected by transition rules, but since JS is used for certain functionality, perhaps the avatar animation might as well be done with something like jQuery('.avatar-container img').fadeOut(500)? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#293>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6IFMOaBi3fkckLpxyHOwdwHX0UVkA8ks5tEQbLgaJpZM4RMz8i> .

[alefi87]

Submitted a PR. Disregard the git weirdness above - it's just one commit and minor changes to two files.

[daattali]

thank you!