Fix #89 v7: Uint64List not supported by dart2js. and v6: Uint64 accessor not supported by dart2js. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find, but can you rebase your branch, seems a lot of my recent refactors for beta2 are being undone and polluting your actual changes. |
|
Done 👍 |
|
Looks good, thanks. I'll get this released with the next beta, I have some other changes I need to include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Flutter Web throws
Uint64List not supported by dart2js.for UUIDv7 andUint64 accessor not supported by dart2js.for UUIDv6 when trying to generate them, respectively.This seems to be related to the following issues:
Uint64Listdoes NOT use js'BigUint64Array, instead of throwing "Uint64List not supported on the web" dart-lang/sdk#50332I found a workaround using
Uint32Listand adjusted the bits. Not sure if this is the optimal solution.