feat: Support Windows and Nightly builds#5
Merged
Conversation
Make the download more portable to support Windows. Add support for `nightly` versions.
robin-aws
requested changes
Sep 23, 2022
robin-aws
left a comment
robin-aws
left a comment
Member
There was a problem hiding this comment.
Nice, thanks! Make sure you delete the old install-dafny.sh script too.
|
|
||
| (async function () { | ||
| try { | ||
| const version = core.getInput("version", { required: true }); |
Member
There was a problem hiding this comment.
What happens exactly if there's no version? The old version had an explicit error message. Might be worth a negative test here.
Collaborator
Author
There was a problem hiding this comment.
Currently this would result in a failed download...
Co-authored-by: Robin Salkeld <salkeldr@amazon.com>
robin-aws
reviewed
Sep 29, 2022
Member
|
I cancelled the CI to save capacity, lmk when you debug and want to try again |
Try and make GHA run again
seebees
force-pushed
the
v2-add-windows-and-nightly
branch
from
53a1c0b to
9bbfbf6
Compare
robin-aws
requested changes
Oct 3, 2022
robin-aws
left a comment
robin-aws
left a comment
Member
There was a problem hiding this comment.
Thanks for adding nightly! See wrinkle below though.
Co-authored-by: Robin Salkeld <salkeldr@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the download more portable to support Windows. Add support for
nightlyversions.