Skip to content
This repository was archived by the owner on Sep 6, 2024. It is now read-only.

Diff Microsoft-built vs. source-built 6.0.100 SDK #9

Open
wants to merge 4 commits into
base: base-6.0.1xx
Choose a base branch
from
Open

Diff Microsoft-built vs. source-built 6.0.100 SDK #9

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c030bc
Source-built SDK from dotnet-format fix PR local tarball build
dagood Oct 23, 2021
c16bba2
Update to newer source-built SDK
dagood Oct 26, 2021
4976a0b
Update to bootstrapped SDK
dagood Oct 27, 2021
7cd51a5
Add diffs and diff diff for final SDK
dagood Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions contents.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,31 +991,15 @@
./sdk/6.0.100/DotnetTools/dotnet-format/ru/Microsoft.CodeAnalysis.VisualBasic.Workspaces.resources.dll
./sdk/6.0.100/DotnetTools/dotnet-format/ru/Microsoft.CodeAnalysis.Workspaces.MSBuild.resources.dll
./sdk/6.0.100/DotnetTools/dotnet-format/ru/Microsoft.CodeAnalysis.Workspaces.resources.dll
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/browser/
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/browser/lib/
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/browser/lib/net6.0/
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/browser/lib/net6.0/System.Text.Encodings.Web.dll
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/win/
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/win/lib/
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/win/lib/net6.0/
./sdk/6.0.100/DotnetTools/dotnet-format/runtimes/win/lib/net6.0/System.Text.Encoding.CodePages.dll
./sdk/6.0.100/DotnetTools/dotnet-format/ru/System.CommandLine.resources.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Collections.Immutable.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.CommandLine.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.CommandLine.Rendering.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Composition.AttributedModel.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Composition.Convention.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Composition.Hosting.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Composition.Runtime.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Composition.TypedParts.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Diagnostics.DiagnosticSource.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.IO.Pipelines.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Reflection.Metadata.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Runtime.CompilerServices.Unsafe.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Text.Encoding.CodePages.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Text.Encodings.Web.dll
./sdk/6.0.100/DotnetTools/dotnet-format/System.Text.Json.dll
./sdk/6.0.100/DotnetTools/dotnet-format/tr/
./sdk/6.0.100/DotnetTools/dotnet-format/tr/dotnet-format.resources.dll
./sdk/6.0.100/DotnetTools/dotnet-format/tr/Microsoft.CodeAnalysis.CSharp.Features.resources.dll
Expand Down Expand Up @@ -1223,7 +1207,6 @@
./sdk/6.0.100/DotnetTools/dotnet-watch/6.0.100-rtm.21522.10/tools/net6.0/any/System.Composition.Hosting.dll
./sdk/6.0.100/DotnetTools/dotnet-watch/6.0.100-rtm.21522.10/tools/net6.0/any/System.Composition.Runtime.dll
./sdk/6.0.100/DotnetTools/dotnet-watch/6.0.100-rtm.21522.10/tools/net6.0/any/System.Composition.TypedParts.dll
./sdk/6.0.100/DotnetTools/dotnet-watch/6.0.100-rtm.21522.10/tools/net6.0/any/System.IO.Pipelines.dll
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this good / expected?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.IO.Pipelines isn't in the shared fx. So if dotnet-watch needs this assembly, this might break it.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the Microsoft-built SDK, according to the overall diff. I can try to track down what was bringing this in the non-bootstrapped build.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to track down what was bringing this in the non-bootstrapped build.

Not getting into this for now. This change makes us have the same DLLs as the Microsoft-built SDK, so we'll assume including it in the non-bootstrapped build was just some version-related issue that bootstrapping fixed.

./sdk/6.0.100/DotnetTools/dotnet-watch/6.0.100-rtm.21522.10/tools/net6.0/any/tr/
./sdk/6.0.100/DotnetTools/dotnet-watch/6.0.100-rtm.21522.10/tools/net6.0/any/tr/dotnet-watch.resources.dll
./sdk/6.0.100/DotnetTools/dotnet-watch/6.0.100-rtm.21522.10/tools/net6.0/any/tr/Microsoft.CodeAnalysis.CSharp.Features.resources.dll
Expand Down Expand Up @@ -1893,10 +1876,6 @@
./sdk/6.0.100/runtimes/any/native/NuGet.props
./sdk/6.0.100/runtimes/any/native/NuGet.RestoreEx.targets
./sdk/6.0.100/runtimes/any/native/NuGet.targets
./sdk/6.0.100/runtimes/browser/
./sdk/6.0.100/runtimes/browser/lib/
./sdk/6.0.100/runtimes/browser/lib/net6.0/
./sdk/6.0.100/runtimes/browser/lib/net6.0/System.Text.Encodings.Web.dll
./sdk/6.0.100/runtimes/win/
./sdk/6.0.100/runtimes/win/lib/
./sdk/6.0.100/runtimes/win/lib/net6.0/
Expand Down Expand Up @@ -2740,7 +2719,6 @@
./sdk/6.0.100/System.Resources.Extensions.dll
./sdk/6.0.100/System.Security.Cryptography.ProtectedData.dll
./sdk/6.0.100/System.ServiceProcess.ServiceController.dll
./sdk/6.0.100/System.Text.Encodings.Web.dll
./sdk/6.0.100/TestHost/
./sdk/6.0.100/testhost.deps.json
./sdk/6.0.100/testhost.dll
Expand Down