Skip to content

Possible solution for handling stale props #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2019

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Mar 2, 2019

I hope to fix #4.

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 3, 2019

benchmark comparison

v1.2.0

Results for benchmark tree-view-rher:
┌─────────┬──────────────┬───────────────────────────────────────────────────────────────────────────────┐
│ Avg FPS │ Render       │ FPS Values                                                                    │
│         │ (Mount, Avg) │                                                                               │
├─────────┼──────────────┼───────────────────────────────────────────────────────────────────────────────┤
│ 41.29   │ 885.3, 1.6   │ 32,34,24,40,48,42,38,40,29,45,44,45,38,52,34,45,38,40,44,42,45,52,49,41,46,46 │
└─────────┴──────────────┴───────────────────────────────────────────────────────────────────────────────┘

Results for benchmark tree-view-rher-simple:
┌─────────┬──────────────┬──────────────────────────────────────────────────────────────────────────────────┐
│ Avg FPS │ Render       │ FPS Values                                                                       │
│         │ (Mount, Avg) │                                                                                  │
├─────────┼──────────────┼──────────────────────────────────────────────────────────────────────────────────┤
│ 46.42   │ 537.4, 1.1   │ 39,47,54,42,41,35,48,49,50,47,50,41,52,43,51,42,48,49,54,45,50,43,47,39,51,50,50 │
└─────────┴──────────────┴──────────────────────────────────────────────────────────────────────────────────┘

53ce171

Results for benchmark tree-view-rher:
┌─────────┬──────────────┬─────────────────────────────────────────────────────────────────────────────────────┐
│ Avg FPS │ Render       │ FPS Values                                                                          │
│         │ (Mount, Avg) │                                                                                     │
├─────────┼──────────────┼─────────────────────────────────────────────────────────────────────────────────────┤
│ 41.05   │ 714.9, 1.6   │ 40,33,26,42,41,39,42,28,45,41,48,47,36,50,32,44,47,36,44,38,37,45,40,47,53,43,47,47 │
└─────────┴──────────────┴─────────────────────────────────────────────────────────────────────────────────────┘

Results for benchmark tree-view-rher-simple:
┌─────────┬──────────────┬────────────────────────────────────────────────────────────────────────────────────────┐
│ Avg FPS │ Render       │ FPS Values                                                                             │
│         │ (Mount, Avg) │                                                                                        │
├─────────┼──────────────┼────────────────────────────────────────────────────────────────────────────────────────┤
│ 43.99   │ 509.7, 1.4   │ 42,37,49,48,39,40,36,42,49,53,41,49,39,49,37,46,36,38,47,48,51,48,51,48,42,45,39,40,40 │
└─────────┴──────────────┴────────────────────────────────────────────────────────────────────────────────────────┘

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 3, 2019

I think the result is tolerable and will merge this.

@dai-shi dai-shi merged commit 2419c6c into master Mar 3, 2019
@dai-shi dai-shi deleted the handling-stale-props branch March 3, 2019 03:16
dai-shi added a commit that referenced this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling stale props?
1 participant