feat: card ui revamp #4630
feat: card ui revamp #4630
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
packages/shared/tailwind/colors.ts
Outdated
| @@ -121,7 +121,7 @@ const colors = { | |||
| 10: '#68A6FC', | |||
| 20: '#5C9BFA', | |||
| 30: '#508CF9', | |||
| 40: '#427EF7', | |||
| 40: '#5C9BFA', | |||
There was a problem hiding this comment.
This should never change actually 🤯
Why is this different now?
|
|
|
More of a feedback to design, but I think there's way to little contrast between what is read and not read. Try to spot the read articles
|
the design specifically mentions no padding, although I guess we can add 1 px to make it look a little cleaner |
It's a bit subtler indeed, but also wonder if it's due to you being used to the old style 😅 I'll raise it to design to see what they have to say! |
@rebelchris |
| @@ -135,7 +138,7 @@ export const ArticleGrid = forwardRef(function ArticleGrid( | |||
| showFeedback && styles.read, | |||
| )} | |||
| > | |||
| <CardTextContainer> | |||
| <CardTextContainer className={classNames(postUiExp && 'mx-4')}> | |||
There was a problem hiding this comment.
I noticed we are primarily using mx-4 but the design seems to say 8px only which is mx-2.
There was a problem hiding this comment.
@sshanzel I think its a bit misleading because if you click in a level or two to see the actual text distance, its 16
Screen.Recording.2025-07-10.at.15.34.47.mov
There was a problem hiding this comment.
If the outer container does not havew the right padding, then yeah, mx-4 should be good.
Changes
Usually I'd post screenshots, but since this is about the post cards themselves, it's probably nicer to just use the preview! 😄
DESIGN
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-915
Preview domain
https://mi-915.preview.app.daily.dev