Better implementation for loading files from a ZIP#75
Better implementation for loading files from a ZIP#75
Conversation
because cx:unzip can not be used to load as html or text. See also commit 4ae7bb4.
|
@josteinaj Can you please review this code? |
|
Not tested locally but looks good 👍 |
|
@josteinaj I would like to see this in a new release. Can you do it? By the way what are we going to do with my other pull requests? |
|
Sorry, I've had too much to do, and I've forgotten about these PRs. I'll try to find time to look at it soon. I haven't reviewed the PRs but I'm sure we can rebase or merge them all into the release. |
|
Cool, thanks. The other PR's are not urgent, I just want to know what to do with them. If you don't like them we can drop them. Or if you think they need more work... |
josteinaj
left a comment
josteinaj
left a comment
There was a problem hiding this comment.
Seems fine. I don't think the tests cover the case with zipped files, but I suspect you've tested it on other projects, and the normal tests passes, so this should be fine.
|
Fixed in #76 (v1.4.0) |
|
Ah yes a test would have been a good idea indeed. I've indeed tested with other projects. |
2 participants
because cx:unzip can not be used to load as html or text.
See also commit 4ae7bb4.