This repository was archived by the owner on Dec 5, 2019. It is now read-only.
Add missing XML comments to public members#185
Merged
Conversation
… Missing XML comment for publicly visible type or member.
Collaborator
|
Thanks for PR @srottem ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a code quality approach I set up my projects to treat all warnings as errors and prevent compilation if any are present. Unfortunately this means that with the current NuGet package for LibLog I have to turn off this setting, otherwise I get a bunch of "warning CS1591: Missing XML comment for publicly visible type or member." errors due to public members from the package being added to my project.
This pull request applies XML code comments to the members that are causing the problem.