Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

use net45 as minimum version#190

Merged
damianh merged 3 commits into
damianh-archive:masterfrom
austinlparker:feature/minNet45
Nov 19, 2018
Merged

use net45 as minimum version#190
damianh merged 3 commits into
damianh-archive:masterfrom
austinlparker:feature/minNet45

Conversation

@austinlparker
Copy link
Copy Markdown
Contributor

this fixes #189 and allows for the library to be imported to projects that target net45.

@@ -1,12 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netcoreapp2.0;net461;net452</TargetFrameworks>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xUnit requires net452

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - restored the test project to net452.

@damianh damianh merged commit 2471c5f into damianh-archive:master Nov 19, 2018
@damianh damianh added this to the v5.0.3 milestone Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support net45 and netstandard2

3 participants