Add support for merged assemblies.#223
Conversation
|
Seems like a reasonable request and PR. Am wondering if there are any edge cases that could trip this up? |
|
Can't think of any so will merge and ship. Am going on your assessment that it is working for you in production ;) |
|
Technically not all the way to "Production", but definitely in our "Production Like" test environment. :) Any chance of an official nuget release soon? |
|
On nuget.org. |
|
Sorry to keep poking, but any chance of a non pre-release version on nuget.org? :) |
|
@damianh There is an official LibLog 5.0.7 release note: https://github.com/damianh/LibLog/releases/tag/v5.0.7 But the 5.0.7 release on nuget includes build number (Making it a pre-release build): https://www.nuget.org/packages/LibLog/5.0.7-build.575 Hopefully there will be an official ver. 5.0.8 that includes #233 :) |
When using LibLog with assemblies that have been merged together with ILRepack the
Type.GetType()calls fail because of the assembly qualified type names that no longer match. The fix is just to fall back on the plain type name without the assembly portion when the first attempt returns null. Rather than change all theType.GetType()calls I added static functions in the base to do it.I couldn't figure out a way to correctly unit test everything from a merged assembly easily. I'm using a build based on this and it is indeed working and all the existing unit tests pass.