Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

Add support for merged assemblies.#223

Merged
damianh merged 1 commit into
damianh-archive:masterfrom
kll:feature/merged-assembly-support
Feb 16, 2019
Merged

Add support for merged assemblies.#223
damianh merged 1 commit into
damianh-archive:masterfrom
kll:feature/merged-assembly-support

Conversation

@kll
Copy link
Copy Markdown
Contributor

@kll kll commented Feb 12, 2019

When using LibLog with assemblies that have been merged together with ILRepack the Type.GetType() calls fail because of the assembly qualified type names that no longer match. The fix is just to fall back on the plain type name without the assembly portion when the first attempt returns null. Rather than change all the Type.GetType() calls I added static functions in the base to do it.

I couldn't figure out a way to correctly unit test everything from a merged assembly easily. I'm using a build based on this and it is indeed working and all the existing unit tests pass.

@damianh
Copy link
Copy Markdown
Collaborator

damianh commented Feb 16, 2019

Seems like a reasonable request and PR. Am wondering if there are any edge cases that could trip this up?

@damianh
Copy link
Copy Markdown
Collaborator

damianh commented Feb 16, 2019

Can't think of any so will merge and ship. Am going on your assessment that it is working for you in production ;)

@damianh damianh merged commit 6463310 into damianh-archive:master Feb 16, 2019
@damianh damianh added this to the v5.0.7 milestone Feb 16, 2019
@kll kll deleted the feature/merged-assembly-support branch February 26, 2019 15:09
@kll
Copy link
Copy Markdown
Contributor Author

kll commented Feb 26, 2019

Technically not all the way to "Production", but definitely in our "Production Like" test environment. :)

Any chance of an official nuget release soon?

@damianh
Copy link
Copy Markdown
Collaborator

damianh commented Mar 3, 2019

On nuget.org.

@kll
Copy link
Copy Markdown
Contributor Author

kll commented Mar 20, 2019

Sorry to keep poking, but any chance of a non pre-release version on nuget.org? :)

@snakefoot
Copy link
Copy Markdown
Contributor

snakefoot commented Mar 31, 2019

@damianh There is an official LibLog 5.0.7 release note:

https://github.com/damianh/LibLog/releases/tag/v5.0.7

But the 5.0.7 release on nuget includes build number (Making it a pre-release build):

https://www.nuget.org/packages/LibLog/5.0.7-build.575

Hopefully there will be an official ver. 5.0.8 that includes #233 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants