-
Notifications
You must be signed in to change notification settings - Fork 81
Fix Angular 21 login by adding APP_INITIALIZER for OIDC authentication #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: damienbod <[email protected]>
Co-authored-by: damienbod <[email protected]>
…iptions Co-authored-by: damienbod <[email protected]>
Copilot
AI
changed the title
[WIP] Fix login functionality in Angular
Fix Angular 21 login by adding APP_INITIALIZER for OIDC authentication
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login was broken because
checkAuth()was only called inAppComponent.ngOnInit(), which occurs after routing initialization. Angular 21 requires OIDC authentication to be resolved before the app bootstraps.Changes
app.module.ts: Add APP_INITIALIZER provider that invokes
checkAuth()during bootstrapapp.component.ts: Subscribe to
isAuthenticated$observable instead of callingcheckAuth()to avoid redundant auth checksdataeventrecords components: Fix
AuthenticatedResulttype handling - extract boolean from result object when passing togetData()Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.