Fix display issues with pasted or uploaded images #3117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @askeew, I will take a look and review it soon — likely on Wednesday. |
danieldaquino
requested changes
Jul 9, 2025
There was a problem hiding this comment.
Thank you @askeew. I added one inline comment.
One other comment is about the commit message format. Please ensure your commit messages follow our contribution guidelines.
Please let me know if you have any questions.
damus/Views/PostView.swift
Outdated
| .contextMenu { contextMenuContent(for: media[index]) } | ||
| } else { | ||
| KFAnimatedImage(media[index].uploadedURL) | ||
| .imageContext(.note, disable_animation: false) | ||
| .configure { view in | ||
| view.framePreloadCount = 3 | ||
| } | ||
| .aspectRatio(contentMode: .fit) |
There was a problem hiding this comment.
We should probably use .fill instead. .fit causes the image to look dissociated with the close button when the image has a more "eccentric" aspect ratio. Examples:
askeew
force-pushed
the
2913-image-display-bug
branch
from
10e3f3c to
bc967b4
Compare
- Fix aspect ratio, use fit - Remove fixed height on image frame to align close button on image - Use overlay instead of ZStack to reduce complexity - Add background to close button to get better contrast in light mode - Change close-image to be a button for better accessibility Changelog-Fixed: Fix aspect ratio on pasted or uploaded images Signed-off-by: Askeew <[email protected]> Closes: damus-io#2913
askeew
force-pushed
the
2913-image-display-bug
branch
from
85a319c to
469980a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fitChecklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Device: iPhone 15, iPhone 13
iOS: 18.5, 17.6.1
Damus: 1.12 (682) 4cf8097, 1.15 (1) ce19e12d
Steps: uploaded and pasted image and videos, tried both single image/video and multiple
Results:
before multiple:
after multiple:
before single:
after single:
