Skip to content

Delta library #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Delta library #1017

wants to merge 4 commits into from

Conversation

dandavison
Copy link
Owner

From @th1000s in #1013 (comment)

With this patch git-delta-lib would become a multi crate which provides both the binary and the library, but both are tied to the same version number 0.0.x. While working on the librarification nothing should change for the delta command line interface, so it gets/keeps its separate crate to signify that (otherwise, to make library changes the number would have to be bumped to 0.13, 0.14 etc. in quick succession and thus new binary releases with no apparent changes would happen).

Once this is stable the number can be bumped and git-delta can provide binary and library interfaces:

--(0.12.0)----(0.12.1)----.   +(0.13.0)------------>           ,---(1.0.0)---->      # git-delta
                           \                                  /
                            `--(0.0.0)---(0.0.1)----(0.0.2)--'                       # git-delta-lib

@dandavison dandavison marked this pull request as draft March 18, 2022 03:13
@dandavison
Copy link
Owner Author

Uploaded 0.0.1 to crates.io

@th1000s
Copy link
Collaborator

th1000s commented Mar 20, 2022

Indeed, leaving this on the existing master branch is probably best, this way everyone with a cloned delta repo can continue working without resetting the upstream. Also, e.g. lib.rs this is now marked as a bin+lib crate!

@extrawurst
Copy link

What is needed to get this librification to get over the finish line? I see the lib on crates just looks like the binary readme, no docs (that I can find). I am wondering when this is ready for primetime in something like my gitui?

@dandavison
Copy link
Owner Author

Hi @extrawurst

What is needed to get this librification to get over the finish line?

Labour :)

It's definitely an interesting and valuable Rust project for someone to work on. Speaking for myself, my job/life isn't currently giving me time to work on anything but essential Delta activities.

@extrawurst
Copy link

Is that labour communicated somewhere so it can be picked up by someone?

@dandavison
Copy link
Owner Author

Good call -- I think that would be your ticket #317, but that wasn't clearly linked to this work. I've added a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants