Skip to content

Conversation

exploide
Copy link
Contributor

I added auto completions for the fish shell.

On the next release, it is probably a good idea to take a note for packagers that this file should be delivered as /usr/share/fish/vendor_completions.d/delta.fish.

@dandavison
Copy link
Owner

Thanks a lot @exploide! I might try to test this myself in the future but it looks great and I'm going to merge it now so that it's available to every others.

@dandavison dandavison merged commit df3ec7f into dandavison:master Aug 19, 2022
@exploide exploide deleted the fish-completions branch August 20, 2022 09:00
@dandavison
Copy link
Owner

#1561 makes use of the shell completion autogeneration feature in Rust's clap library. It's output looks similar to yours, so I'm going to delete all the shell completion scripts that are checked into the repo and instead encourage users to use the output of delta --generate-completion fish. Please let me know if you don't think that's the right course. And thanks a lot for doing this in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants