Skip to content

Make upload() fail if client & server schema versions are not in sync#724

Merged
yarikoptic merged 3 commits into
masterfrom
gh-722
Jul 22, 2021
Merged

Make upload() fail if client & server schema versions are not in sync#724
yarikoptic merged 3 commits into
masterfrom
gh-722

Conversation

@jwodder

@jwodder jwodder commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

Closes #722.

@jwodder jwodder added the minor Increment the minor version when merged label Jul 21, 2021
@codecov

codecov Bot commented Jul 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #724 (5e6a9a1) into master (ee38041) will increase coverage by 0.06%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   84.06%   84.12%   +0.06%     
==========================================
  Files          59       59              
  Lines        5661     5689      +28     
==========================================
+ Hits         4759     4786      +27     
- Misses        902      903       +1     
Flag Coverage Δ
unittests 84.12% <96.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 90.90% <90.90%> (-0.03%) ⬇️
dandi/exceptions.py 100.00% <100.00%> (ø)
dandi/tests/test_dandiapi.py 100.00% <100.00%> (ø)
dandi/upload.py 84.02% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee38041...5e6a9a1. Read the comment docs.

@yarikoptic yarikoptic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes request

Comment thread dandi/dandiapi.py Outdated
Comment thread dandi/dandiapi.py Outdated
Comment thread dandi/dandiapi.py Outdated
Comment thread dandi/upload.py Outdated
@yarikoptic

Copy link
Copy Markdown
Member

Thank you @jwodder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upload should fail if client uses outdated schema

2 participants