Added Ambilight+Hue state control #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elupus
requested changes
Mar 19, 2022
Collaborator
|
You also need to add tests for this. |
elupus
requested changes
Mar 19, 2022
Collaborator
elupus
left a comment
elupus
left a comment
There was a problem hiding this comment.
Looks good, just make sure it is tested too.
Contributor
Author
|
Basic test added |
elupus
approved these changes
Apr 2, 2022
Collaborator
elupus
left a comment
elupus
left a comment
There was a problem hiding this comment.
Looked good. Sorry I forgot this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added possibility to check and change state of Ambilight+Hue function. This works on all Ambilight Philips TV from what I know...
I'm using this API in my HA integration https://github.com/Mr-Groch/ambihue