Added new function to read recordings/list #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elupus
requested changes
Jan 17, 2023
Collaborator
elupus
left a comment
elupus
left a comment
There was a problem hiding this comment.
The types don't seem to line up with your use. In one case the recordings is a dict, in others a list and you are not converting.
If you run mypy on the file it aught to be complaining.
Contributor
Author
|
Thanks for pointing this out. Mypy shows no errors (for my changes) anymore. |
elupus
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in preparation on adding a function to Home Assistant to show the recordings of my TV, I added the needed functions to this library.
I hope I understood the typing.py well enough.
At least this works for my Philips 55OLED706/12.