Skip to content

fixes issue #781 #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2022
Merged

fixes issue #781 #909

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c91c859
fix for #781
ktsaou Feb 10, 2018
b5b0d36
handle all cases where y0 is equal to y1
ktsaou Feb 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/dygraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,16 +2533,22 @@ Dygraph.prototype.computeYAxisRanges_ = function(extremes) {
if (!ypadCompat) {
// When using yRangePad, adjust the upper/lower bounds to add
// padding unless the user has zoomed/panned the Y axis range.

y0 = axis.computedValueRange[0];
y1 = axis.computedValueRange[1];

// special case #781: if we have no sense of scale, center on the sole value.
if (y0 === y1) {
y0 -= 0.5;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a log scale, this could drop y below zero, which will produce NaNs. In the logscale branch of the conditional on line 2546, you can halve y0 and double y1 instead.

y1 += 0.5;
}

if (logscale) {
y0 = axis.computedValueRange[0];
y1 = axis.computedValueRange[1];
var y0pct = ypad / (2 * ypad - 1);
var y1pct = (ypad - 1) / (2 * ypad - 1);
axis.computedValueRange[0] = utils.logRangeFraction(y0, y1, y0pct);
axis.computedValueRange[1] = utils.logRangeFraction(y0, y1, y1pct);
} else {
y0 = axis.computedValueRange[0];
y1 = axis.computedValueRange[1];
span = y1 - y0;
axis.computedValueRange[0] = y0 - span * ypad;
axis.computedValueRange[1] = y1 + span * ypad;
Expand Down