Use custom ASGI app to serve SPA properly#85
Open
scootermon wants to merge 1 commit into
Open
Conversation
|
@scootermon is attempting to deploy a commit to the danyi1212's projects Team on Vercel. A member of the Team first needs to authorize it. |
scootermon
force-pushed
the
main
branch
2 times, most recently
from
d7c2584 to
64c4cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing links is completely broken right now because the frontend is only served on
/.This PR implements a custom ASGI app on top of the static app that will properly serve the SPA for unknown links.
I added the
ignore_prefixeslist so you still get proper 404 pages for non-frontend links like/api/thisDoesNotExist