Add generic redeemRewards function ; removed redundant code #517
Conversation
src/plugins/proposal.ts
Outdated
| if (state.name === 'ContributionReward') { | ||
| const pluginState = await state.plugin.entity.fetchState() | ||
| pluginAddress = pluginState.address | ||
| } else { |
There was a problem hiding this comment.
why this condition is needed ?
There was a problem hiding this comment.
The old functions are not exactly the same - they are similar but not the same. There is a different in the way pluginAddress is fetched between the functions and we need to distinguish between the ways. Without this condition some of the tests fail.
There was a problem hiding this comment.
there is a need to understand why this behave differently .
does pluginAddress get different value for different cases ? why ?
There was a problem hiding this comment.
Yes it gets a different value when state.name is ContributionReward or different.
src/plugins/proposal.ts
Outdated
| ).address | ||
| } | ||
| let method | ||
| if (state.name === 'ContributionRewardExt') { |
There was a problem hiding this comment.
if ((state.name === 'ContributionRewardExt') || (state.name === 'Competition')) {
Resolves: #516
This PR is necessary to solve issue daostack/alchemy#1993 in Alchemy