Auction4reputation #491
Merged
Auction4reputation #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
force-pushed
the
auction4reputation
branch
from
fa135be to
ea8d3d6
Compare
leviadam
reviewed
Jul 12, 2018
| require(now >= auctionsStartTime,"bidding is enable only after bidding auctionsStartTime"); | ||
| require(token.transferFrom(msg.sender, wallet, _amount),"transferFrom should success"); | ||
| // solium-disable-next-line security/no-block-members | ||
| auctionId = ((now - auctionsStartTime)/numberOfAuctions); |
There was a problem hiding this comment.
I think this calculation is not correct
There was a problem hiding this comment.
👍 fixed at ed733dc
leviadam
reviewed
Jul 12, 2018
| // solium-disable-next-line security/no-block-members | ||
| auctionId = (now - auctionsStartTime)/auctionPeriod; | ||
| Auction storage auction = auctions[auctionId]; | ||
| auction.totalBid += _amount; |
leviadam
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scheme to conduct auction on reputation using erc20 tokens.