Added AuthorizedMintRep scheme #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
reviewed
Jan 7, 2020
orenyodfat
suggested changes
Jan 7, 2020
| /** | ||
| * @dev Throws if called by an unauthorized account. | ||
| */ | ||
| modifier onlyAuthorized() { |
| activationEndTime = _activationEndTime; | ||
| repRewardLeft = _maxRepReward; | ||
| authorizedAddress = _authorizedAddress; | ||
| limitRepReward = _maxRepReward != 0; |
There was a problem hiding this comment.
what does it means != 0 ?
There was a problem hiding this comment.
If it is not 0 I want to skip the check of the limit of reputation
There was a problem hiding this comment.
this is strange syntax .
do we have a test which cover this case ?
There was a problem hiding this comment.
Yes, what's weird about this syntax?
|
|
||
| /** | ||
| * @dev reputationMint function | ||
| * @param _beneficiary the beneficiary address to redeem for |
| /** | ||
| * @dev reputationMint function | ||
| * @param _beneficiary the beneficiary address to redeem for | ||
| * @param _amount the agreementHash hash |
| * @param _beneficiary the beneficiary address to redeem for | ||
| * @param _amount the agreementHash hash | ||
| */ | ||
| function reputationMint(address _beneficiary, uint256 _amount) external onlyAuthorized { |
There was a problem hiding this comment.
does this function should return bool same as the reputation mint ?
There was a problem hiding this comment.
No, but it can if we want it to.
orenyodfat
approved these changes
Jan 7, 2020
orenyodfat
suggested changes
Jan 7, 2020
orenyodfat
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #703