Skip to content

Conversation

@tylerkron
Copy link
Contributor

@tylerkron tylerkron commented Sep 11, 2025

User description

Summary

  • Consolidates 6 separate dependabot PRs into a single clean update
  • Updates NuGet packages: SQLitePCLRaw.bundle_e_sqlite3, protobuf-net, MSTest packages
  • Updates GitHub Actions: setup-dotnet and github-script actions
  • Avoids the massive line ending diffs that dependabot created

Updated Packages

NuGet Packages

  • SQLitePCLRaw.bundle_e_sqlite3: 3.0.1 → 3.0.2
  • protobuf-net: 3.1.17 → 3.2.56
  • MSTest.TestAdapter: 3.10.3 → 3.10.4 (all test projects)
  • MSTest.TestFramework: 3.10.3 → 3.10.4 (all test projects)

GitHub Actions

  • actions/setup-dotnet: v4 → v5
  • actions/github-script: v7 → v8

Test Plan

  • Build solution successfully compiles
  • Tests pass on compatible projects
  • All package references updated consistently across projects
  • GitHub Actions workflow files updated

This replaces the following dependabot PRs that had massive line ending diffs:

🤖 Generated with Claude Code


PR Type

Other


Description

  • Update NuGet packages: SQLitePCLRaw, protobuf-net, MSTest packages

  • Update GitHub Actions: setup-dotnet v4→v5, github-script v7→v8

  • Consolidate 6 separate dependabot PRs into single update

  • Maintain consistent package versions across test projects


Diagram Walkthrough

flowchart LR
  A["Dependabot Updates"] --> B["NuGet Packages"]
  A --> C["GitHub Actions"]
  B --> D["SQLitePCLRaw 3.0.1→3.0.2"]
  B --> E["protobuf-net 3.1.17→3.2.56"]
  B --> F["MSTest 3.10.3→3.10.4"]
  C --> G["setup-dotnet v4→v5"]
  C --> H["github-script v7→v8"]
Loading

File Walkthrough

Relevant files
Dependencies
9 files
build.yaml
Update setup-dotnet action to v5                                                 
+1/-1     
prebuild.yaml
Update github-script action to v8                                               
+2/-2     
release.yaml
Update setup-dotnet action to v5                                                 
+1/-1     
Daqifi.Desktop.Bootloader.Test.csproj
Update MSTest packages to 3.10.4                                                 
+2/-2     
Daqifi.Desktop.Common.Test.csproj
Update MSTest packages to 3.10.4                                                 
+2/-2     
Daqifi.Desktop.DataModel.Test.csproj
Update MSTest packages to 3.10.4                                                 
+2/-2     
Daqifi.Desktop.IO.Test.csproj
Update MSTest packages to 3.10.4                                                 
+2/-2     
Daqifi.Desktop.Test.csproj
Update MSTest and protobuf-net packages                                   
+3/-3     
Daqifi.Desktop.csproj
Update SQLitePCLRaw.bundle_e_sqlite3 to 3.0.2                       
+1/-1     

Updates the following packages and actions:
- SQLitePCLRaw.bundle_e_sqlite3: 3.0.1 → 3.0.2
- protobuf-net: 3.1.17 → 3.2.56
- MSTest.TestAdapter: 3.10.3 → 3.10.4 (all test projects)
- MSTest.TestFramework: 3.10.3 → 3.10.4 (all test projects)
- actions/setup-dotnet: v4 → v5 (GitHub Actions)
- actions/github-script: v7 → v8 (GitHub Actions)

This consolidates 6 separate dependabot PRs into a single update
to avoid massive line ending diffs caused by dependabot.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@tylerkron tylerkron requested a review from a team as a code owner September 11, 2025 01:45
@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Action Major Update

Moving from github-script v7 to v8 may introduce breaking changes in the Node runtime or API surface used in the scripts; validate that the scripts for adding/removing PR comments still behave as expected in PR events.

- name: Leave a comment if PR title is invalid
  if: ${{ failure() }}
  uses: actions/github-script@v8
  with:
    script: |
      const prNumber = context.payload.pull_request.number;
      const acceptablePrefixes = ['feat', 'fix', 'docs', 'deps', 'chore'];
Workflow Compatibility

setup-dotnet updated to v5; ensure that caching/installation behavior and inputs remain compatible with current workflow needs on windows-latest and .NET 9.

- name: Setup .NET
  uses: actions/setup-dotnet@v5
  with:
    dotnet-version: 9.0.x
Runtime Packaging

Updating SQLitePCLRaw.bundle_e_sqlite3 to 3.0.2 can alter native asset resolution; verify app startup and SQLite operations across target platforms to ensure no native binding/load issues.

<PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.2" />
<PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.11" />

@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
Avoid mixed SQLite bundles

The project incorrectly references two different SQLitePCLRaw bundles
(bundle_e_sqlite3 and bundle_green) in Daqifi.Desktop.csproj. This is
unsupported and can cause runtime conflicts. The suggestion is to remove one of
the bundles to ensure stability.

Examples:

Daqifi.Desktop/Daqifi.Desktop.csproj [80-81]
		<PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.2" />
		<PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.11" />

Solution Walkthrough:

Before:

<!-- Daqifi.Desktop/Daqifi.Desktop.csproj -->
<ItemGroup>
  ...
  <PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.2" />
  <PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.11" />
  ...
</ItemGroup>

After:

<!-- Daqifi.Desktop/Daqifi.Desktop.csproj -->
<ItemGroup>
  ...
  <!-- Choose one bundle and remove the other. For example: -->
  <PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.2" />
  <!-- Also ensure any other SQLitePCLRaw.* packages are on a consistent version -->
  ...
</ItemGroup>
Suggestion importance[1-10]: 9

__

Why: This suggestion correctly identifies a critical issue where two conflicting SQLite bundles (bundle_e_sqlite3 and bundle_green) are referenced, which can lead to unpredictable runtime failures.

High
Security
Pin action to commit SHA

Pin the action to a specific commit SHA to prevent supply-chain attacks via
mutable tags. This locks the workflow to a known-good version and improves
reproducibility. Update the reference to the v5 commit SHA.

.github/workflows/build.yaml [14]

-uses: actions/setup-dotnet@v5
+uses: actions/setup-dotnet@<commit-sha-for-v5>
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly recommends pinning the actions/setup-dotnet action to a specific commit SHA, which is a security best practice to prevent supply-chain attacks via mutable tags.

Medium
  • More

@github-actions
Copy link

📊 Code Coverage Report

Summary

Summary
Generated on: 9/11/2025 - 1:47:42 AM
Coverage date: 9/11/2025 - 1:47:30 AM - 9/11/2025 - 1:47:38 AM
Parser: MultiReport (5x Cobertura)
Assemblies: 5
Classes: 120
Files: 154
Line coverage: 11.7% (673 of 5726)
Covered lines: 673
Uncovered lines: 5053
Coverable lines: 5726
Total lines: 17544
Branch coverage: 11.6% (239 of 2043)
Covered branches: 239
Total branches: 2043
Method coverage: Feature is only available for sponsors

Coverage

DAQiFi - 10.2%
Name Line Branch
DAQiFi 10.2% 10.7%
Daqifi.Desktop.App 3% 0%
Daqifi.Desktop.Channel.AbstractChannel 28.5% 30%
Daqifi.Desktop.Channel.AnalogChannel 88.4%
Daqifi.Desktop.Channel.Channel 11.5% 0%
Daqifi.Desktop.Channel.ChannelColorManager 100% 100%
Daqifi.Desktop.Channel.DataSample 90.4%
Daqifi.Desktop.Channel.DigitalChannel 0%
Daqifi.Desktop.Commands.CompositeCommand 0% 0%
Daqifi.Desktop.Commands.HostCommands 0%
Daqifi.Desktop.Commands.WeakEventHandlerManager 0% 0%
Daqifi.Desktop.Configuration.FirewallConfiguration 90.6% 66.6%
Daqifi.Desktop.Configuration.WindowsFirewallWrapper 64% 68.4%
Daqifi.Desktop.ConnectionManager 40.9% 55.8%
Daqifi.Desktop.Converters.BoolToActiveStatusConverter 0% 0%
Daqifi.Desktop.Converters.BoolToConnectionStatusConverter 0% 0%
Daqifi.Desktop.Converters.BoolToStatusColorConverter 0% 0%
Daqifi.Desktop.Converters.ConnectionTypeToColorConverter 0% 0%
Daqifi.Desktop.Converters.ConnectionTypeToUsbConverter 0% 0%
Daqifi.Desktop.Converters.InvertedBoolToVisibilityConverter 0% 0%
Daqifi.Desktop.Converters.ListToStringConverter 0% 0%
Daqifi.Desktop.Converters.NotNullToVisibilityConverter 0% 0%
Daqifi.Desktop.Converters.OxyColorToBrushConverter 0% 0%
Daqifi.Desktop.Device.AbstractStreamingDevice 5.4% 2.9%
Daqifi.Desktop.Device.DeviceMessage 0%
Daqifi.Desktop.Device.HidDevice.HidDeviceFinder 0% 0%
Daqifi.Desktop.Device.HidDevice.HidFirmwareDevice 0%
Daqifi.Desktop.Device.NativeMethods 0%
Daqifi.Desktop.Device.SerialDevice.SerialDeviceFinder 0% 0%
Daqifi.Desktop.Device.SerialDevice.SerialDeviceHelper 0% 0%
Daqifi.Desktop.Device.SerialDevice.SerialStreamingDevice 7.7% 15%
Daqifi.Desktop.Device.SerialDevice.UsbDevice 0% 0%
Daqifi.Desktop.Device.WiFiDevice.DaqifiDeviceFinder 0% 0%
Daqifi.Desktop.Device.WiFiDevice.DaqifiStreamingDevice 19.6% 0%
Daqifi.Desktop.DialogService.DialogService 0% 0%
Daqifi.Desktop.DialogService.ServiceLocator 0% 0%
Daqifi.Desktop.DuplicateDeviceCheckResult 100%
Daqifi.Desktop.Exporter.OptimizedLoggingSessionExporter 29.7% 32.9%
Daqifi.Desktop.Exporter.SampleData 0%
Daqifi.Desktop.Helpers.BooleanConverter`1 0% 0%
Daqifi.Desktop.Helpers.BooleanToInverseBoolConverter 0% 0%
Daqifi.Desktop.Helpers.BooleanToVisibilityConverter 0%
Daqifi.Desktop.Helpers.EnumDescriptionConverter 100% 100%
Daqifi.Desktop.Helpers.IntToVisibilityConverter 0% 0%
Daqifi.Desktop.Helpers.MyMultiValueConverter 0%
Daqifi.Desktop.Helpers.NaturalSortHelper 100% 100%
Daqifi.Desktop.Helpers.VersionHelper 98.2% 66.2%
Daqifi.Desktop.Logger.DatabaseLogger 0% 0%
Daqifi.Desktop.Logger.LoggedSeriesLegendItem 0% 0%
Daqifi.Desktop.Logger.LoggingContext 0%
Daqifi.Desktop.Logger.LoggingManager 0% 0%
Daqifi.Desktop.Logger.LoggingSession 26.6% 0%
Daqifi.Desktop.Logger.PlotLogger 0% 0%
Daqifi.Desktop.Logger.SummaryLogger 0% 0%
Daqifi.Desktop.Loggers.FirmwareUpdatationManager 5.8% 0%
Daqifi.Desktop.MainWindow 0% 0%
Daqifi.Desktop.Migrations.InitialSQLiteMigration 0%
Daqifi.Desktop.Migrations.LoggingContextModelSnapshot 0%
Daqifi.Desktop.Models.AddProfileModel 0%
Daqifi.Desktop.Models.DaqifiSettings 86.3% 100%
Daqifi.Desktop.Models.DebugDataCollection 0% 0%
Daqifi.Desktop.Models.DebugDataModel 0% 0%
Daqifi.Desktop.Models.Notifications 0%
Daqifi.Desktop.Models.SdCardFile 0%
Daqifi.Desktop.Services.WindowsPrincipalAdminChecker 0%
Daqifi.Desktop.Services.WpfMessageBoxService 0%
Daqifi.Desktop.UpdateVersion.VersionNotification 0% 0%
Daqifi.Desktop.View.AddChannelDialog 0% 0%
Daqifi.Desktop.View.AddProfileConfirmationDialog 0% 0%
Daqifi.Desktop.View.AddprofileDialog 0% 0%
Daqifi.Desktop.View.ConnectionDialog 0% 0%
Daqifi.Desktop.View.DebugWindow 0% 0%
Daqifi.Desktop.View.DeviceLogsView 0% 0%
Daqifi.Desktop.View.DuplicateDeviceDialog 0% 0%
Daqifi.Desktop.View.ErrorDialog 0% 0%
Daqifi.Desktop.View.ExportDialog 0% 0%
Daqifi.Desktop.View.FirmwareDialog 0% 0%
Daqifi.Desktop.View.Flyouts.ChannelsFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.DevicesFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.FirmwareFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.LiveGraphFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.LoggedSessionFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.NotificationsFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.SummaryFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.UpdateProfileFlyout 0% 0%
Daqifi.Desktop.View.SelectColorDialog 0% 0%
Daqifi.Desktop.View.SettingsDialog 0% 0%
Daqifi.Desktop.View.SuccessDialog 0% 0%
Daqifi.Desktop.ViewModels.AddChannelDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.AddProfileConfirmationDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.AddProfileDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.ConnectionDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.DaqifiViewModel 0% 0%
Daqifi.Desktop.ViewModels.DeviceLogsViewModel 0% 0%
Daqifi.Desktop.ViewModels.DeviceSettingsViewModel 0% 0%
Daqifi.Desktop.ViewModels.DuplicateDeviceDialogViewModel 0%
Daqifi.Desktop.ViewModels.ErrorDialogViewModel 0%
Daqifi.Desktop.ViewModels.ExportDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.FirmwareDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.SelectColorDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.SettingsViewModel 0%
Daqifi.Desktop.ViewModels.SuccessDialogViewModel 0%
Daqifi.Desktop.WindowViewModelMapping.IWindowViewModelMappingsContract 0%
Daqifi.Desktop.WindowViewModelMapping.WindowViewModelMappings 0%
Daqifi.Desktop.Bootloader - 20.6%
Name Line Branch
Daqifi.Desktop.Bootloader 20.6% 17.3%
Daqifi.Desktop.Bootloader.Crc16 100% 100%
Daqifi.Desktop.Bootloader.Exceptions.FirmwareUpdateException 0%
Daqifi.Desktop.Bootloader.FirmwareDownloader 82% 66.6%
Daqifi.Desktop.Bootloader.Pic32Bootloader 0% 0%
Daqifi.Desktop.Bootloader.Pic32BootloaderMessageConsumer 0% 0%
Daqifi.Desktop.Bootloader.Pic32BootloaderMessageProducer 80.9% 100%
Daqifi.Desktop.Bootloader.WifiFirmwareDownloader 0% 0%
Daqifi.Desktop.Bootloader.WifiModuleUpdater 0% 0%
Daqifi.Desktop.Common - 45.9%
Name Line Branch
Daqifi.Desktop.Common 45.9% 33.3%
Daqifi.Desktop.Common.Loggers.AppLogger 42.1% 33.3%
Daqifi.Desktop.Common.Loggers.NoOpLogger 100%
Daqifi.Desktop.DataModel - 100%
Name Line Branch
Daqifi.Desktop.DataModel 100% ****
Daqifi.Desktop.DataModel.Device.DeviceInfo 100%
Daqifi.Desktop.IO - 23.9%
Name Line Branch
Daqifi.Desktop.IO 23.9% 18.9%
Daqifi.Desktop.IO.Messages.Consumers.AbstractMessageConsumer 0% 0%
Daqifi.Desktop.IO.Messages.Consumers.MessageConsumer 0% 0%
Daqifi.Desktop.IO.Messages.Consumers.TextMessageConsumer 0% 0%
Daqifi.Desktop.IO.Messages.Decoders.ProtobufDecoder 100% 75%
Daqifi.Desktop.IO.Messages.MessageEventArgs`1 0%
Daqifi.Desktop.IO.Messages.Producers.MessageProducer 81% 80%

Coverage report generated by ReportGeneratorView full report in build artifacts

@tylerkron tylerkron merged commit 01317c0 into main Sep 11, 2025
3 checks passed
@tylerkron tylerkron deleted the deps/consolidated-dependabot-updates branch September 11, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants