feat: Add channels from two device(#51) #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Daqifi.Desktop.IO/Messages/Consumers/MessageConsumer.cs # Daqifi.Desktop/MainWindow.xaml # Daqifi.Desktop/View/AddprofileDialog.xaml.cs # Daqifi.Desktop/ViewModels/DaqifiViewModel.cs
# Conflicts: # Daqifi.Desktop.IO/Messages/Consumers/MessageConsumer.cs
…aqifi/daqifi-desktop into 51-add-channels-from-2-devices * '51-add-channels-from-2-devices' of https://github.com/daqifi/daqifi-desktop: chore: Try to update whole project in .net 8 (#67) Managed two device channel list and profile settings # Conflicts: # Daqifi.Desktop.IO.Test/Messages/Decoders/ProtobugDecoderTests.cs # Daqifi.Desktop.IO.Test/Messages/MessageTypes/DaqifiOutMessageTests.cs # Daqifi.Desktop.IO/Daqifi.Desktop.IO.csproj # Daqifi.Desktop.IO/Messages/Consumers/MessageConsumer.cs # Daqifi.Desktop.IO/Messages/Decoders/ProtobufDecoder.cs # Daqifi.Desktop.IO/Messages/MessageTypes/DaqifiOutMessage.cs # Daqifi.Desktop.IO/Messages/MessageTypes/ProtobufMessage.cs # Daqifi.Desktop/ConnectionManager.cs # Daqifi.Desktop/Device/AbstractStreamingDevice.cs # Daqifi.Desktop/Models/AddProfileModel.cs # Daqifi.Desktop/View/Flyouts/UpdateProfileFlyout.xaml # Daqifi.Desktop/ViewModels/DaqifiViewModel.cs
tylerkron
requested changes
Dec 14, 2024
Contributor
tylerkron
left a comment
tylerkron
left a comment
There was a problem hiding this comment.
Some of this works and some doesn't. I can add multiple devices, configure device settings, add channels and save that as a profile. All of that works great. However, I can't actually stream with two devices.
For example, I added a real DAQiFi device and added a simulator device. Only one device's data gets shown / logged. Is this expected and you'd handle streaming in another ticket. or should this work as part of this ticket?
Picture as an example:
Contributor
|
Only 1 device is still getting captured on the live graph and logged data. To reproduce:
|
tylerkron
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
1.Add two device
2.Add channel from two device
3.Save settings of two device and ,
4.Profile activation supports two device