Groundwork for future .NET 6 upgrade #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
July 16, 2022 21:54
Closed
| bin | ||
| obj | ||
| AnalysisReport.sarif | ||
| debug.log |
Contributor
There was a problem hiding this comment.
Should this be checked in?
Contributor
Author
There was a problem hiding this comment.
nope, should not be
danmiller973
approved these changes
Aug 26, 2022
Contributor
danmiller973
left a comment
danmiller973
left a comment
There was a problem hiding this comment.
This looks good, but are there any changes we need to make in the installer (i.e. .net framework checks)?
Contributor
Author
|
@danmiller973 yes likely a ton of updates for the installer. I'll make those in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade was huge, so this is an incremental step. Updated a bunch of libs along the way