Fix containment check for reversed ranges #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Apr 6, 2018
src/plots/cartesian/set_convert.js
Outdated
| coord >= ax.r2l(ax.range[0]) && | ||
| coord <= ax.r2l(ax.range[1]) | ||
| ); | ||
| return Math.min(r0, r1) <= coord && coord <= Math.max(r0, r1); |
There was a problem hiding this comment.
Perhaps:
var r0 = ax.r2l(ax.range[0]);
var r1 = ax.r2l(ax.range[1]);
if(r0 < r1) {
return coord >= r0 && coords <= r1;
} else {
// reversed axis case
return coord <= r0 && coords >= r1;
}would perform (one comparison instead of Math.min + Math.max) and arguably more readable.
There was a problem hiding this comment.
Thanks, done. I will try to figure out how to recreate this pull request against the main repo.
darabos
pushed a commit
that referenced
this pull request
Oct 2, 2018
* treat zero as valid fixes plotly#2660 * PR suggestions: toBe instead of toEqual
darabos
pushed a commit
that referenced
this pull request
Oct 2, 2018
Fix for number 0 treated as invalid in hover (#1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I committed the "before" baseline to demonstrate the issue. You can see the fix in the second commit's diff:
This example is a bit unusual. Who uses upside-down bar charts?! In real life I hit this issue with a horizontal bar chart where I wanted the order of the groups in the chart to match the order in the legend:
I set
autorange: 'reverse'and the texts disappeared:If I remove
cliponaxis: false, the texts are clipped:I'm open to suggestions, but this PR is aimed at fixing the version with the missing texts.