This repository was archived by the owner on Jun 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Allow subtypes of EventEmitters in @Outputs #76
Labels
Comments
Upping the importance of this for two reasons: Firstly, per some discovery showing it comes up a lot. Secondly, when this goes wrong it currently has no fallback behavior and it complains about the $event variables when it can't identify their type. Also confirmed that Therefore the goals are twofold:
|
Ah! That is exactly what I was hoping would exist! |
MichaelRFairhurst
added a commit
to MichaelRFairhurst/angular2-dart-analyzer
that referenced
this issue
Nov 28, 2016
Use the mostSpecificTypeArgument method API to get the stream type regardless of the inheritance tree and generics defined within it.
MichaelRFairhurst
added a commit
that referenced
this issue
Nov 28, 2016
* Allow Stream<T> and subtypes of it in outputs, refs #76 Use the mostSpecificTypeArgument method API to get the stream type regardless of the inheritance tree and generics defined within it. Plus style fixes including in some old code
PR #89 merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Currently, code such as
will fail.
Per @scheglov, its possible that
EventEmitter
itself is already a subtype of the required type, which may be simplyStream<T>
.Note as well that we should do this right, tracking where the subtype relationship specifies the type parameters, ie
class MyIntEventEmitter extends EventEmitter<int> { ... }
If this is considerably more work then a new ticket should be made for this edge case.
The text was updated successfully, but these errors were encountered: