This repository was archived by the owner on Jun 20, 2019. It is now read-only.
Solve issue #103 generic inherited types still unresolved #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to a class-instantiation paradigm; instantiate the type to bounds before building the component (still using custom instantiation logic while issue dart-archive#91 is blocked), and use that to resolve getters/setters up the inheritance tree. No change to the @input() and @output() workflows because those don't involve inheritance.
scheglov
approved these changes
Dec 1, 2016
| // Since <my-comp></my-comp> represents an instantiation of MyComp, | ||
| // especially when MyComp is generic or its superclasses are, we need | ||
| // this. Cache instead of passing around everywhere. | ||
| InterfaceType _instantiatedClassType; |
There was a problem hiding this comment.
Please use DartDoc style comments, /// or /** */.
EOL comments are not attached well enough to their target.
| @@ -297,6 +302,7 @@ class BuildUnitDirectivesTask extends SourceBasedAnalysisTask | |||
| AbstractDirective _createDirective( | |||
| ast.ClassDeclaration classDeclaration, ast.Annotation node) { | |||
| ClassElement classElement = classDeclaration.element; | |||
| _instantiatedClassType = _instantiateClass(classElement); | |||
There was a problem hiding this comment.
You could do the same with ClassElement.
For example _currentElement and _currentType.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to a class-instantiation paradigm; instantiate the type to bounds
before building the component (still using custom instantiation logic
while issue #91 is blocked), and use that to resolve getters/setters up
the inheritance tree.
No change to the @input() and @output() workflows because those don't
involve inheritance.